Skip to content

Fixes#1

Merged
bwengals merged 27 commits intobwengals:find_MAP-float32from
kyleabeauchamp:mletest
Aug 13, 2017
Merged

Fixes#1
bwengals merged 27 commits intobwengals:find_MAP-float32from
kyleabeauchamp:mletest

Conversation

@kyleabeauchamp
Copy link

@kyleabeauchamp kyleabeauchamp commented Aug 12, 2017

  1. Fetch and merge upstream
  2. Added failing test for MLE gives incorrect value with Uniform RVs pymc-devs/pymc#2482
  3. Fixed two test failures that were present in your PR

aasensio and others added 27 commits August 1, 2017 22:13
* Some changes to docs

* Added plots of continuous dist

* More compact plotting for docs
* fixed multivariate

* multivariate fix for pvals > 1

* updated multivariate with hack

* bugfix

* float64 patch to multivariate's multinomial

* reinstated p.squeeze(), accidentally took it out

* updated based on failed test

* further minor fixes to multinomial

* Force push to restart Travis
* [WIP] implement random method for LKJCorr

using the algorithm in LKJ 2009(vine method based on a C-vine)

* pep8 fix

* import random method

* Revert "import random method"

This reverts commit 42e620e.

* restrict dimension n to n > 1, fix random sample for n = 2

* unify parameter naming between LKJCorr and LKJCholeskyCov

* improved random method

* Bug fix in shape

* Add test

* fix test

* pep8 clean up, fixed test warning

* improved random method

* forked R code for random method

generated Corr matrix is now positive definite.
* Use testpoint as mean in adapt_diag

* Allow missing warning in nuts check

* Fix to dtype in quadpotential
For potential usage in SMC/ABC where we need random method to generate sample. Still not encourage to use.
Extra open bracket was breaking it.
Typo in _repr_latex_ for Flat distribution
* Draft intro page

* Fixed header in intro

* Updated text with suggested edits

* Converted tabs to spaces throughout

* Reorganized sections in intro

* Minor edits to intro

* Fixed some bad rst

* Added all data to example

* Added image with example in intro

* Edited text in intro

* Fixed typo

* Added intro to index
* use Bayesian bootstrapping to compute weights

* speed up _log_post_trace

* replace bootstrapping with bootstrap
* fix AR(1) log likelihood

* add AR model

* fix testing floats

* resolve conflict

* Resolve conflict 2

* refine notebook

* notebook minor fix
* fix MvNormal error

(cherry picked from commit b763b08)

* add import to MvNormal directly
This is a quick patch to fix the travis fail after the change of the default init.
* Moved Constant to subclass of Continuous

* Added missing distributions from distributions api docs

* Changed Constant to be subclass of Distribution

* Reverted changes and added deprecation warning for Constant

* Moved Constant reference in init

* Moved Constant reference in init

* Added Constant to discrete.rst

* Fixed import error

* Removed duplicate/redundant warning for ConstantDist
@kyleabeauchamp
Copy link
Author

re pymc-devs#2468

@kyleabeauchamp
Copy link
Author

kyleabeauchamp commented Aug 12, 2017

There are still ~3 failures that you need to fix in your PR after merging this, they all seem to be cases where the starting point for the MLE has a non-finite logP.

@kyleabeauchamp
Copy link
Author

Probably due to bad starting points or something.

@aseyboldt
Copy link

aseyboldt commented Aug 12, 2017

Maybe just wait with this until pymc-devs#2482 is merged. We can then cherry-pick the commits with the tests and add them to pymc-devs#2499 after that has been rebased.

@bwengals
Copy link
Owner

wow cool, thanks for doing this!!

@bwengals bwengals merged commit 537d0bb into bwengals:find_MAP-float32 Aug 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.